iampeter/pixelplanet
1
Fork 0
forked from ppfun/pixelplanet
Code Pull Requests Activity

imagine killing websocket server because of one client error, lmao

Browse Source
This commit is contained in:
HF 2020-04-17 19:36:27 +02:00
parent dd61ff064d
commit d8424a666d
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/core/logger.js
View File

@ -17,6 +17,9 @@ const logger = createLogger({
new transports.Console(),
],
});
logger.error.bind(logger);
logger.info.bind(logger);
logger.warn.bind(logger);
export const proxyLogger = createLogger({
transports: [

10
src/socket/SocketServer.js
View File

@ -67,7 +67,9 @@ class SocketServer extends WebSocketEvents {
});
this.wss = wss;
wss.on('error', logger.error);
wss.on('error', (e) => {
logger.error(`WebSocket Server Error ${e.message}`);
});
wss.on('connection', async (ws, req) => {
ws.isAlive = true;
@ -84,7 +86,9 @@ class SocketServer extends WebSocketEvents {
ws.send(`"${ws.name}"`);
}
ws.on('error', logger.error);
ws.on('error', (e) => {
logger.error(`WebSocket Client Error for ${ws.name}: ${e.message}`);
});
ws.on('close', () => {
// is close called on terminate?
// possible memory leak?
@ -129,7 +133,7 @@ class SocketServer extends WebSocketEvents {
try {
ws._socket.write(buffer);
} catch (error) {
logger.error('(!) Catched error on write socket:', error);
logger.error(`WebSocket broadcast error: ${error.message}`);
}
});
}