From d4d8f9c046d8427454d21e6a3d9e9cf203ac13da Mon Sep 17 00:00:00 2001 From: HF Date: Wed, 7 Sep 2022 14:36:46 +0200 Subject: [PATCH] check for regUser existance in User.js --- src/data/User.js | 4 +++- src/data/sql/RegUser.js | 15 +++++---------- 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/src/data/User.js b/src/data/User.js index 1a0b8e2..7771521 100644 --- a/src/data/User.js +++ b/src/data/User.js @@ -180,7 +180,9 @@ class User { } incrementPixelcount(amount = 1) { - incrementPixelcount(this.regUser, amount); + if (this.regUser) { + incrementPixelcount(this.regUser, amount); + } } async getTotalPixels() { diff --git a/src/data/sql/RegUser.js b/src/data/sql/RegUser.js index c740a33..b0f9158 100644 --- a/src/data/sql/RegUser.js +++ b/src/data/sql/RegUser.js @@ -218,13 +218,11 @@ const incrementLoop = async () => { await sequelize.transaction(async (t) => { while (incrementQueue.length) { const [model, amount] = incrementQueue.pop(); - if (model) { - // eslint-disable-next-line no-await-in-loop - await model.increment( - ['totalPixels', 'dailyTotalPixels'], - { by: amount, transaction: t }, - ); - } + // eslint-disable-next-line no-await-in-loop + await model.increment( + ['totalPixels', 'dailyTotalPixels'], + { by: amount, transaction: t }, + ); } return true; }); @@ -239,9 +237,6 @@ setInterval(() => { console.log('INCREMENTATION QUEUE SIZE', incrementQueue.length, pushLoop); }, 300000); export async function incrementPixelcount(model, amount) { - if (!model) { - return; - } const exists = incrementQueue.find((q) => q[0] === model); if (exists) { exists[1] += amount;