sallbet/pixelplanet-fork
1
Fork 1
forked from ppfun/pixelplanet
Code Pull Requests Activity

fix elint warnings in VoxelPainterControls

Browse Source
This commit is contained in:
HF 2024-01-20 20:45:55 +01:00
parent 18f7e14f79
commit 7f684bb47a
1 changed files with 12 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
src/controls/VoxelPainterControls.js
View File

@ -194,10 +194,6 @@ class VoxelPainterControls {
document.removeEventListener('keyup', this.onDocumentKeyUp, false); document.removeEventListener('keyup', this.onDocumentKeyUp, false);
} }
getZoomScale() {
return 0.95 ** zoomSpeed;
}
rotateLeft(angle) { rotateLeft(angle) {
this.sphericalDelta.theta -= angle; this.sphericalDelta.theta -= angle;
} }
@ -234,14 +230,6 @@ class VoxelPainterControls {
this.panOffset.add(v); this.panOffset.add(v);
} }
dollyIn(dollyScale) {
this.scale /= dollyScale;
}
dollyOut(dollyScale) {
this.scale *= dollyScale;
}
// //
// event callbacks - update the object state // event callbacks - update the object state
// //
@ -285,10 +273,11 @@ class VoxelPainterControls {
dollyEnd.set(event.clientX, event.clientY); dollyEnd.set(event.clientX, event.clientY);
dollyDelta.subVectors(dollyEnd, dollyStart); dollyDelta.subVectors(dollyEnd, dollyStart);
const scaleDelta = 0.95 ** zoomSpeed;
if (dollyDelta.y > 0) { if (dollyDelta.y > 0) {
this.dollyIn(this.getZoomScale()); this.scale /= scaleDelta;
} else if (dollyDelta.y < 0) { } else if (dollyDelta.y < 0) {
this.dollyOut(this.getZoomScale()); this.scale *= scaleDelta;
} }
dollyStart.copy(this.dollyEnd); dollyStart.copy(this.dollyEnd);
this.update(); this.update();
@ -308,15 +297,15 @@ class VoxelPainterControls {
this.update(); this.update();
} }
handleMouseUp(/* event */) { // eslint-disable-next-line class-methods-use-this
// no-op handleMouseUp() {}
}
handleMouseWheel(event) { handleMouseWheel(event) {
const scaleDelta = 0.95 ** zoomSpeed;
if (event.deltaY < 0) { if (event.deltaY < 0) {
this.dollyOut(this.getZoomScale()); this.scale *= scaleDelta;
} else if (event.deltaY > 0) { } else if (event.deltaY > 0) {
this.dollyIn(this.getZoomScale()); this.scale /= scaleDelta;
} }
this.forceNextUpdate = true; this.forceNextUpdate = true;
} }
@ -412,7 +401,7 @@ class VoxelPainterControls {
const distance = Math.sqrt(dx * dx + dy * dy); const distance = Math.sqrt(dx * dx + dy * dy);
dollyEnd.set(0, distance); dollyEnd.set(0, distance);
dollyDelta.set(0, (dollyEnd.y / dollyStart.y) ** zoomSpeed); dollyDelta.set(0, (dollyEnd.y / dollyStart.y) ** zoomSpeed);
this.dollyIn(dollyDelta.y); this.scale /= dollyDelta.y;
dollyStart.copy(dollyEnd); dollyStart.copy(dollyEnd);
} }
@ -426,9 +415,8 @@ class VoxelPainterControls {
if (enableRotate) this.handleTouchMoveRotate(event); if (enableRotate) this.handleTouchMoveRotate(event);
} }
handleTouchEnd(/* event */) { // eslint-disable-next-line class-methods-use-this
// no-op handleTouchEnd() {}
}
// //
// event handlers - FSM: listen for events and reset state // event handlers - FSM: listen for events and reset state
@ -638,6 +626,7 @@ class VoxelPainterControls {
this.state = STATE.NONE; this.state = STATE.NONE;
} }
// eslint-disable-next-line class-methods-use-this
onContextMenu(event) { onContextMenu(event) {
event.preventDefault(); event.preventDefault();
} }