From dbf46556c8266475e7e6b30202cdabd0bf499ede Mon Sep 17 00:00:00 2001 From: HF Date: Wed, 24 Jan 2024 00:57:22 +0100 Subject: [PATCH] remove stopPropagation from Controler touch even to make detection of phones in client.js better --- src/client.js | 5 +++-- src/controls/PixelPainterControls.js | 3 +-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/client.js b/src/client.js index 95ed7bea..6d4c5606 100644 --- a/src/client.js +++ b/src/client.js @@ -36,10 +36,11 @@ persistStore(store, {}, () => { }); // check if on mobile - function checkMobile() { + window.imMobile = function checkMobile() { + delete window.imMobile; store.dispatch(setMobile(true)); } - document.addEventListener('touchstart', checkMobile, { once: true }); + document.addEventListener('touchstart', window.imMobile, { once: true }); // listen for resize function onWindowResize() { diff --git a/src/controls/PixelPainterControls.js b/src/controls/PixelPainterControls.js index 8fe936b2..80c21b77 100644 --- a/src/controls/PixelPainterControls.js +++ b/src/controls/PixelPainterControls.js @@ -224,7 +224,6 @@ class PixelPainterControls { onTouchStart(event) { event.preventDefault(); - event.stopPropagation(); document.activeElement.blur(); this.renderer.cancelStoreViewInState(); @@ -262,7 +261,6 @@ class PixelPainterControls { onTouchEnd(event) { event.preventDefault(); - event.stopPropagation(); if (event.touches.length) { // still other touches left return; @@ -394,6 +392,7 @@ class PixelPainterControls { onWheel(event) { event.preventDefault(); + event.stopPropagation(); document.activeElement.blur(); const { deltaY } = event;